-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(proposal): Dogfooding of trestle in the oscal-compass community #58
Conversation
Signed-off-by: Chris Butler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@butler54 I completely agree that using trestle
here is a good opportunity. I want to link the CNCF design proposal example. I think we could tailor this for the template. What you have already lines up well. I would recommend adding , Goals
, and Non-Goals
Impact/Key Questions
.
Editing my recommendation:
You already have Definition of Done
, so maybe adding Scope
to communicate Non-Goals
. WDYT?
Signed-off-by: Chris Butler <[email protected]>
@jpower432 / @jflowers - I've made an incremental change, however, looking at the CNCF design proposal template. I think we should faithfully recreate it. Why: It gives us a bit of a springboard to a long term goal: trestle, by default, is expected by the CNCF to be use used to enforce templates (maybe I am being ambitious). if we agree this is a good idea moving forward I'll translate it into the proposal template @jpower432's referenced with a few tweaks (I would like to see the metadata stored as a a yaml header). |
@butler54 I am on board with this. The template we have is almost as comprehensive as the CNCF design proposal template so we might as well align on the naming of the sections for consistency/reuse. Another example of a good comprehensive template is Kubernetes Enhancements. |
I like it! I think it's a good ambition. |
…pipeline Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Okay this should be good to review now / ready to roll. As mentioned in the document the project will need to be updated to mandate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Two nits/non-blocking comments on the workflow.
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
Signed-off-by: Chris Butler <[email protected]>
It's good to be merged now based on your feedback. |
This is a proposal to use
trestle
within the proposals process.The intent that this should be debated on two levels:
The validity of doing so
The document structure of the proposal, such that it can be used as the actual template if approved.